Some people have said that if you have 18's the ride is slightly more fidgety. But I found going from the standard 20vt wheels (16") to the 18's no real noticeable difference in quality of ride. (The oe ride after all is not super smooth in any case).
Personally for the little in extra £'s, between 17's and 18's. 18's would always be my first choice.
I also think they look much nicer than 17's - but this of course is down to personal taste.
Last thing I would say, you really ought to lower the car after fitting bigger wheels. For some reason, even though you should be fitting the same size rolling radius, with the lower profile rubber and large alloy the car can tend to look a little high, and wheel arch gaps look a little to big.
Eibachs are perfect for this, they lower front by around 15-20mm, and the rear buy 35mm, bringing the car down a little over the new wheels, but maintaining a good ride and practicality.